Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto release: Creating PR overnight #1972

Merged
merged 5 commits into from
Feb 14, 2019
Merged

Auto release: Creating PR overnight #1972

merged 5 commits into from
Feb 14, 2019

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Feb 14, 2019 •
edited
Loading

Description:

  • This PR only automatically create the PR that must be currently manually approved, will have master as base
  • next PR will automate the merge if this will do what we want

Thank you! 🚀

For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@sabau
test the release PR process
6ae8f06 
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@sabau
change trigger time
7a37f94 
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@sabau sabau changed the title auto release pr first step Auto release: Creating PR overnight Feb 14, 2019
@sabau
chanfelog
b12af2a 
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #1972 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1972   +/-   ##
========================================
  Coverage    95.51%   95.51%           
========================================
  Files          121      121           
  Lines         2611     2611           
  Branches       121      121           
========================================
  Hits          2494     2494           
  Misses         108      108           
  Partials         9        9
Impacted Files Coverage Δ
tasks/createReleasePR.js 42.85% <ø> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Feb 14, 2019 •
edited
Loading

Codecov Report

Merging #1972 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1972   +/-   ##
========================================
  Coverage    95.51%   95.51%           
========================================
  Files          121      121           
  Lines         2611     2611           
  Branches       121      121           
========================================
  Hits          2494     2494           
  Misses         108      108           
  Partials         9        9
Impacted Files Coverage Δ
tasks/createReleasePR.js 42.85% <ø> (ø) ⬆️

@faboweb faboweb merged commit f1809de into develop Feb 14, 2019
@faboweb faboweb deleted the sabau/auto-release-PR-first-step branch February 14, 2019 17:28
@faboweb faboweb mentioned this pull request Feb 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faboweb faboweb faboweb approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

@jbibla jbibla Awaiting requested review from jbibla jbibla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabau @faboweb